[PATCH] D53044: [ELF] Don't warn on undefined symbols if UnresolvedPolicy::Ignore is used

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Symbols.cpp:268-271
+  if (!Config->WarnSymbolOrdering ||
+      (Sym->isUndefined() &&
+       Config->UnresolvedSymbols == UnresolvedPolicy::Ignore))
     return;
----------------
It's a nit, but I wouldn't merge the two conditions to make it look nicer.

  if (!Config->WarnSymbolOrdering)
    return;

  // comment
  if (Sym->isUndefined() && ...)
    return;

The first condition is obvious, and it is better not to mix it with some more complicated condition, which needs a comment.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53044