[PATCH] D53004: [WebAssembly] Saturating float to int intrinsics

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 14:49:03 PDT 2018


aheejin added a comment.

Do we need a new `SDNode` and a new lowering routine in ISelLowering for each of new intrinsics? Can't we use the intrinsics directly in *.td files like instructions?



================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrConv.td:106
 
+} // defs = [ARGUMENTS]
+
----------------
We can not delete this :)


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrConv.td:118
+
+let Defs = [ARGUMENTS] in {
+
----------------
This too


Repository:
  rL LLVM

https://reviews.llvm.org/D53004





More information about the llvm-commits mailing list