[PATCH] D53064: [llvm-nm] Include the text "@FILE" in the output of --help

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 13:33:54 PDT 2018


rupprecht added a comment.

In https://reviews.llvm.org/D53064#1260942, @mstorsjo wrote:

> In https://reviews.llvm.org/D53064#1260876, @rupprecht wrote:
>
> > I'm not sure `@FILE` syntax is actually supported by llvm-nm. At least, I can't find any unit tests that test it, and `@` is not present in llvm-nm.cpp. I think that change should come first?
>
>
> It does support it just fine right now (even if there's no explicit unit test for it). llvm-nm.cpp calls ParseCommandLineOptions, which internally calls ExpandResponseFiles, so this is implicit in more or less every llvm tool.


I see. Would you mind adding a simple test that llvm-nm actually handles `@FILE` as a resource file and not as a file? Not all tools use ParseCommandLineOptions, so it's not unreasonable that someone may need to change llvm-nm to avoid it for some reason.


Repository:
  rL LLVM

https://reviews.llvm.org/D53064





More information about the llvm-commits mailing list