[PATCH] D52923: AMDGPU/GlobalIsel: Legalize SI.load.const by lowering to G_LOAD
Tom Stellard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 10 12:39:25 PDT 2018
tstellar added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:274
+ return true;
+ case AMDGPUIntrinsic::SI_load_const: {
+ MachineFunction &MF = MIRBuilder.getMF();
----------------
arsenm wrote:
> Should we really be adding support for the old/broken intrinsics here?
It's necessary as a transition step for Mesa to global-isel. Mesa still emits these and we can't change mesa to emit actual load instructions, because then if we need to fallback to SelectionDAG, we will fail.
Repository:
rL LLVM
https://reviews.llvm.org/D52923
More information about the llvm-commits
mailing list