[PATCH] D52002: Switch optimization for known maximum switch values

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D52002#1260549, @ayonam wrote:

> In https://reviews.llvm.org/D52002#1260409, @hans wrote:
>
> > Sorry for the slow response.
> >
> > This is looking promising. I have a few comments, and also this needs a good test.
>
>
> Should I be adding a test to the "test" directory or the "unittests" directory?  Or is there somewhere else that I should add the test to?


`test/CodeGen/X86/` e.g.; or some other arch.
*Ideally* //please// do use `llvm/utils/update_llc_test_checks.py`, and put the original tests
(i.e. without this patch) in a separate review, so this review shows how the tests *change*.
Obviously `$ ninja check-llvm-codegen` should pass.


Repository:
  rL LLVM

https://reviews.llvm.org/D52002