[PATCH] D52426: [X86] Move X86DAGToDAGISel::matchBEXTRFromAnd() into X86ISelLowering

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 04:37:59 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/CodeGen/X86/bmi-x86_64.ll:105
 
 define i64 @non_bextr64(i64 %x) {
+; BEXTR-SLOW-LABEL: non_bextr64:
----------------
lebedev.ri wrote:
> RKSimon wrote:
> > Why is this call non_bextr64?
> That is how you named it when adding in rL232580 / https://github.com/llvm-mirror/llvm/commit/cbaefea0c0c1792390375b20c31b7c1fe8d0d2c7
> Should i rename it?
Whoops, typo, s/you//.
Still, should i rename it?


Repository:
  rL LLVM

https://reviews.llvm.org/D52426





More information about the llvm-commits mailing list