[PATCH] D52830: [ELF] - Set sh_info and sh_link for .rela.plt sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 10 03:22:57 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D52830#1258953, @emaste wrote:

> I backported the change to lld 6.0 currently in FreeBSD-HEAD and it has the expected behaviour, but for my test case I think `sh_info` should reference `.got.plt` not `.plt` - note the address marked with `########` below.


I referenced '.plt' mostly for naming consistency ('.rela.plt' -> '.plt') (And gold seems do the same). 
But I think you are right since it relocates entries in .got.plt first of all, so technically it would be correct to reference the '.got.plt'.
It also makes the implementation a bit simpler. I'll update the patch.


https://reviews.llvm.org/D52830





More information about the llvm-commits mailing list