[PATCH] D53064: [llvm-nm] Include the text "@FILE" in the output of --help

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: phosek, pcc, rupprecht, enderby, rnk.

libtool requires this text to be present, in order to conclude that the tool supports response files.


Repository:
  rL LLVM

https://reviews.llvm.org/D53064

Files:
  test/tools/llvm-nm/libtool-response-file.test
  tools/llvm-nm/llvm-nm.cpp


Index: tools/llvm-nm/llvm-nm.cpp
===================================================================
--- tools/llvm-nm/llvm-nm.cpp
+++ tools/llvm-nm/llvm-nm.cpp
@@ -183,6 +183,8 @@
 cl::opt<bool> NoLLVMBitcode("no-llvm-bc",
                             cl::desc("Disable LLVM bitcode reader"));
 
+cl::extrahelp HelpResponse("\nPass @FILE as argument to read options from FILE.\n");
+
 bool PrintAddress = true;
 
 bool MultipleFiles = false;
Index: test/tools/llvm-nm/libtool-response-file.test
===================================================================
--- /dev/null
+++ test/tools/llvm-nm/libtool-response-file.test
@@ -0,0 +1,4 @@
+RUN: llvm-nm --help | FileCheck %s
+Check that the output of llvm-nm --help contains the literal text @FILE; this
+indicates to libtool that llvm-nm does support response files.
+CHECK: @FILE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53064.168956.patch
Type: text/x-patch
Size: 837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181010/cbadf4e5/attachment.bin>