[PATCH] D53044: [ELF] Don't warn on undefined symbols when reading call graph profile

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:689
+        Config->UnresolvedSymbols != UnresolvedPolicy::Ignore)
+      warnUnorderableSymbol(Sym);
     if (const auto *SymD = dyn_cast<Defined>(Sym))
----------------
It reads strangely: "If a symbol is not undefined (or ...) then warnUnorderableSymbol"
Makes think that we reporting a warning for defined symbols.

I think if that check should be made it should be inside the `warnUnorderableSymbol`

Also, should it check the `if (Config->Shared)` condition at some point?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53044