[PATCH] D52999: [FileCheck] Annotate input dump
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 9 19:30:34 PDT 2018
jdenny added a comment.
In https://reviews.llvm.org/D52999#1259882, @george.karpenkov wrote:
> @jdenny Sorry I'm still struggling to understand what exactly are you doing.
Sorry. It's obviously not as self-explanatory as I was hoping. I've probably been staring at it too long. Thanks for letting me know.
> You have one example in the revision description, and some examples in tests. The examples in tests are hard to read because they are also tested using FileCheck.
>
> Could you add a few more examples in the revision description, and add a detailed explanation of what your feature is doing, and what is the exact semantics of added annotations?
> (what exactly is "chk"? I guess short for "check"? And "sam" short for "same"? The semantics of ~, ^ and x also eludes me).
I've extended the description as you suggest. Please let me know if it's still confusing.
https://reviews.llvm.org/D52999
More information about the llvm-commits
mailing list