[PATCH] D52948: [WebAssembly] Fix fneg lowering
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 9 17:52:10 PDT 2018
aheejin added inline comments.
================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:747
define <4 x float> @neg_v4f32(<4 x float> %x) {
- %a = fsub <4 x float> <float 0., float 0., float 0., float 0.>, %x
+ %a = fsub fast <4 x float> <float 0.0, float 0.0, float 0.0, float 0.0>, %x
ret <4 x float> %a
----------------
tlively wrote:
> aheejin wrote:
> > To make this to work, does a floating point instruction has to have `fast` attribute, or only some of these [[ http://llvm.org/docs/LangRef.html#fast-math-flags | fast-math flags ]]?
> Looks like only `nsz` was necessary.
One-line comment on why `nsz` is necessary would be good
Repository:
rL LLVM
https://reviews.llvm.org/D52948
More information about the llvm-commits
mailing list