[PATCH] D51248: Support for remapping profile data, for sample-based profiling.

Richard Smith - zygoloid via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 16:36:27 PDT 2018


rsmith added inline comments.


================
Comment at: unittests/ProfileData/SampleProfTest.cpp:120
+
+    FunctionSamples *ReadFooSamples = Reader->getSamplesFor(FooName);
+    ASSERT_TRUE(ReadFooSamples != nullptr);
----------------
davidxl wrote:
> directly using raw name will break compact format testing.
`getSamplesFor` converts the name to MD5 if the profile is in compact format.


Repository:
  rL LLVM

https://reviews.llvm.org/D51248





More information about the llvm-commits mailing list