[PATCH] D32564: AArch64: compress jump tables to minimum size needed to reach destinations

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 16:34:07 PDT 2018


jfb added a comment.

In https://reviews.llvm.org/D32564#1259372, @evandro wrote:

> In https://reviews.llvm.org/D32564#1259155, @jfb wrote:
>
> > Do you have specific worries? Or at least a timeline? Seems the patch can be reviewed without waiting for your exploration.
>
>
> Yes, I do.  Exynos limits the size of jump tables, resulting in a daisy chain of smaller jump tables.  This patch changes the jump table code, so I'd like to evaluate the performance impact, unless this pass is gated by `-Os`.


Do you have an ETA?

If that ETA is too far, then Tim do you think doing `-Os` first (with a flag to force it, say `-O2 -mcompress-jump-tables`) is OK, with other optimizer settings later (when Exynos stuff comes back)?


Repository:
  rL LLVM

https://reviews.llvm.org/D32564





More information about the llvm-commits mailing list