[PATCH] D53044: [ELF] Don't warn on undefined symbols when reading call graph profile

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 15:23:48 PDT 2018


MaskRay added a comment.

`elf::warnUnorderableSymbol(const Symbol *Sym)` is used in 1) reading call graph profile sections 2) `--symbol-ordering-file=`

FWIW, `ld.bfd` just ignores undefined symbols with `--symbol-ordering-file=`. I don't like that behavior and I think lld is right to give some warnings as it currently does. But regarding call graph profile, when linking a shared object with some undefined symbols, I feel the `UnresolvedPolicy::Ignore` mechanism (`--shared` implies `Ignore`) can be reused to suppress such warnings.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53044





More information about the llvm-commits mailing list