[PATCH] D45213: [COFF][LLD] Add link support for precompiled headers .objs
    Zachary Turner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Oct  9 14:18:52 PDT 2018
    
    
  
zturner added a comment.
BTW, sorry this took so long for anyone to review.  I think partly it's because nobody here really taken the time to understand in detail how MS precompiled headers works, so we were all hoping someone else would review it.  :-/
Anyway, at least from my point of view (unless someone else chimes in) this looks good provided it works (which you say it does) and it has tests (which it does) and the last remaining issues I outlined are fixed.
https://reviews.llvm.org/D45213
    
    
More information about the llvm-commits
mailing list