[PATCH] D53029: [llvm-objcopy] Add -F|--target compatibility

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 12:18:25 PDT 2018


jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.

I think this is probably fine. I think having the error is better than not having it. I'm just concerned someone somewhere is using GNU objcopy in the way mentioned in the error. I'm fine treating this as an error and only switching behavior if and when someone hits an issue.

So LGTM. I'd wait on one more person to cast their vote on this situation.


Repository:
  rL LLVM

https://reviews.llvm.org/D53029





More information about the llvm-commits mailing list