[PATCH] D53031: Expand comment for MinGW driver.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 11:18:20 PDT 2018


smeenai added inline comments.


================
Comment at: lld/MinGW/Driver.cpp:10
+//
+// MinGW is a GNU development environment for Windows. It consists with GNU
+// tools such as GCC and GNU ld. Unlike Cygwin, there's no POSIX-compatible
----------------
Should be either "consists of" or "comes with"


================
Comment at: lld/MinGW/Driver.cpp:16
+//
+// Being a native development tool, a MinGW linker is not very differnet from
+// Microsoft link.exe, so a MinGW linker can be implemented as a thin wrapper
----------------
differnet -> different


================
Comment at: lld/MinGW/Driver.cpp:18
+// Microsoft link.exe, so a MinGW linker can be implemented as a thin wrapper
+// for lld/COFF. This driver takes Unix-ish command line options, translate them
+// to Windows-ish ones, and then passes them to lld/COFF.
----------------
translate -> translates


================
Comment at: lld/MinGW/Driver.cpp:21
+//
+// When this driver calls lld/COFF driver, it passes a hidden option "-lldmingw"
+// along with other user-supplied options, to run lld/COFF linker in "MinGW
----------------
calls lld/COFF driver -> calls **the** lld/COFF driver?


================
Comment at: lld/MinGW/Driver.cpp:22
+// When this driver calls lld/COFF driver, it passes a hidden option "-lldmingw"
+// along with other user-supplied options, to run lld/COFF linker in "MinGW
+// mode".
----------------
run lld/COFF linker -> run **the** lld/COFF linker?


================
Comment at: lld/MinGW/Driver.cpp:26
+// There are subtle differences between MS link.exe and GNU ld/MinGW, and GNU
+// ld/MinGW implemented a few GNU-specific features. Such features are directly
+// implemented in lld/COFF and enabled only when the linker is running in MinGW
----------------
implemented -> implements?


https://reviews.llvm.org/D53031





More information about the llvm-commits mailing list