[PATCH] D53021: lld-link: Use /pdbsourcepath: for more places when present.

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: COFF/PDB.cpp:226
+    // FIXME: make_absolute() should accept sys::path::Style::windows.
+    // Then we should pass that here.
+    sys::fs::make_absolute(FileName);
----------------
thakis wrote:
> Hm, thinking about this a bit more it's not clear what passing a style to make_absolute() should do I suppose :-) .pdb files should contain Windows paths. PDBs created on a non-Windows host without passing /pdbsourcepath: don't, but it's not clear what else we could do -- cwd on a non-Windows host is a non-Windows base path. Maybe I should update the comment that this is just weird in cross builds and that people should pass /pdbsourcepath: there.
Sounds reasonable.  Just yesterday for example I uploaded a patch that relies on generating PDBs that contain UNIX paths.  So I guess we should remove all Windows-isms from this and other places.


https://reviews.llvm.org/D53021