[PATCH] D53021: lld-link: Use /pdbsourcepath: for more places when present.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Personally, I found that the way how Go handles pathnames is better than other languages and libraries. In Go, pathname separator is always "/" even on Windows. That means you have to convert from/to native Windows paths by replacing "\" with "/" when you do IO, but having one internal representation makes coding much easier. For example, concatenating a directory name and a filename is as easy as Dir + "/" + Filename; you don't need anything like sys::path::append. Unfortunately, that's not how we handle pathnames in LLVM, though. I'm just saying.



================
Comment at: COFF/PDB.cpp:221
 
+static void pdbMakeAbsolute(SmallVectorImpl<char> &FileName) {
+  if (sys::path::is_absolute(FileName, sys::path::Style::windows))
----------------
Can you write a justification as a function comment as to why we want to embed a full path to a PDB?


https://reviews.llvm.org/D53021