[PATCH] D52934: [FPEnv] PatternMatcher support for checking FNEG ignoring signed zeros
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 9 09:43:00 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D52934#1258977, @cameron.mcinally wrote:
> Update 'ignore signed zero' acronym to "NSZ".
>
> I decided against the suffix change we discussed, @spatel. It appears that the IRBuilder also uses the prefix format for "NSW" and similar. Any objections to this? There are subtle differences here, so I could be persuaded otherwise.
>
> Also update the CHECKS for a newly added test (r343936).
`NSW` is a flag *on an instruction*. It's not a 'fneg operation of NSZ instruction'.
Suffix variants are cleaner IMO. Would be great to stick to them, and migrate the rest.
Repository:
rL LLVM
https://reviews.llvm.org/D52934
More information about the llvm-commits
mailing list