[PATCH] D53002: Create a new symbol file plugin for cross-platform PDB symbolization
Aleksandr Urakov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 9 08:00:50 PDT 2018
aleksandr.urakov added a comment.
It's great! Especially thanks for comments!
I haven't looked the whole patch yet, I'll finish it tomorrow, ok?
================
Comment at: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:307
std::make_shared<Function>(sc.comp_unit, pdb_func.getSymIndexId(),
- func_type_uid, mangled, func_type, func_range);
+ func_type_uid, mangled, nullptr, func_range);
----------------
Why shouldn't we pass a type here? Isn't it unrelated to the new plugin?
https://reviews.llvm.org/D53002
More information about the llvm-commits
mailing list