[PATCH] D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

Thanks for the description Clement,

In https://reviews.llvm.org/D52932#1258740, @courbet wrote:

> Hi Andrea, thanks for the comments.
>
> I think there are two independent points that we're discussing here:
>  1 - Where we're putting the generated table
>  2 - How we specify the table.
>
> Regarding (1):
>  The goal of this patch is to move the pfm counters out of the SchedModels (see PR39165), because different CPUs with different PFM counters can use the same sched model (e.g. sandybridge).


Sorry. I didn't realize this patch was trying to fix that issue.
The use case for this change was not very clear to me. I though it was just a simple: "how to inherit a default set of PMCs, so that I didn't have to specify the same set over and over..".

I still think it is a preferrable solution to not touch MCSubtargetInfo. That being said, I don't have a strong opinion; other reviewers are definitely more knowledgeable than me on exegesis..

Andrea


Repository:
  rL LLVM

https://reviews.llvm.org/D52932