[PATCH] D52900: [PowerPC]Disable randomized address space on Linux ppc64le

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 9 07:22:42 PDT 2018


lei added a comment.

For PPC this needs to be done for both `tsan` and `msan`.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:1998
+#elif SANITIZER_PPC64V2
+  // Disable ASLR for Linux PPC64LE.
+  int old_personality = personality(0xffffffff);
----------------
nemanjai wrote:
> The comment does not match the macro. I expect that `SANITIZER_PPC64V2` means:
> "Sanitizer turned on, platform is PPC, ELFv2 ABI". The ELFv2 ABI does not necessarily suggest Linux on little endian. For example, FreeBSD big endian uses the same ABI.
FreeBSD defines `SANITIZER_FREEBSD`.  This is only for PPCLE.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52900





More information about the llvm-commits mailing list