[PATCH] D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack

[Zaara Syeda via Phabricator via llvm-commits]

syzaara added inline comments.
Herald added a subscriber: jsji.


================
Comment at: llvm/include/llvm/CodeGen/MachineFrameInfo.h:37
+    int FrameIdx;
+    unsigned DstReg;
+  };
----------------
syzaara wrote:
> MatzeB wrote:
> > If `DstReg` must be a physical register then you could use `MCPhysReg` instead of `unsigned`.
> I'm preferring to keep it as unsigned so that it is consistent with unsigned Reg (the other register variable in the class).
> 
> If you'd like me to change it, I can go ahead with that. Would you also want me to change the function definitions for unsigned getDstReg() and void setDstReg(unsigned SpillReg). 
> 
> And what about the users of this function, like:
> 
> ```
>         unsigned SpilledReg = CSI[I].getDstReg();
>         unsigned CFIRegister = MF.addFrameInst(MCCFIInstruction::createRegister(
>             nullptr, MRI->getDwarfRegNum(Reg, true),
>             MRI->getDwarfRegNum(SpilledReg, true)));
> ```
> 
> SpilledReg is passed to getDwarfRegNum as unsigned.
> 
@MatzeB can you please provide some suggestions on the question above?


https://reviews.llvm.org/D39386