[PATCH] D52999: [FileCheck] Annotate input dump

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D52999#1258477, @jdenny wrote:

> 1. Make changes to include/llvm/Support/FileCheck.h and lib/Support/FileCheck.cpp, which gather the list of diagnostics.
> 2. Make changes to utils/FileCheck/FileCheck.cpp, which converts the list of diagnostics to annotations on the input.
> 3. Adjust command-line option and env var.
> 4. Expose colorsEnabled in WithColor.h.
>
>   On second thought, these are not logically distinct changes as none of them really has much purpose on its own.  You might just consider reviewing files in the above order.  Your call.  Let me know.


Actually, 3 and 4 are logically distinct.  There just isn't much code associated with them, so I'm not sure splitting them off would address your concern.  Still, let me know what would help you to review.


https://reviews.llvm.org/D52999