[PATCH] D52961: [RISCV] Introduce the RISCVMatInt::generateInstSeq helper

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 8 19:06:40 PDT 2018


asb added a comment.

In https://reviews.llvm.org/D52961#1258446, @sabuasal wrote:

> The helper makes it clear to follow. Thanks!
>
> I am just not sure why you did the change to prefer add to addiw when for 64bit?  is addi faster than addiw?


No real reason to prefer one or the other when they're semantically identical. It's mostly to be closer to gas/gcc which uses addi at least for the isInt<12> case.


https://reviews.llvm.org/D52961





More information about the llvm-commits mailing list