[PATCH] D52210: [LLVM-C] Add C APIs to access DebugLoc info
Josh Berdine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 8 15:48:26 PDT 2018
jberdine added inline comments.
================
Comment at: lib/IR/Core.cpp:1162
+const char *LLVMGetDebugLocDirectory(LLVMValueRef Val, unsigned *Length) {
+ assert(Length && "Length must be non-null");
+ StringRef S;
----------------
compnerd wrote:
> Not sure I understand the comment about `_Nonnull` not being able to check-able.
This is an entry point that gets called from other language bindings via their foreign function interfaces, which are unlikely to check `_Nonnull`, or even be able to "see" it since they are essentially written against the ABI.
Repository:
rL LLVM
https://reviews.llvm.org/D52210
More information about the llvm-commits
mailing list