[PATCH] D49168: [LV] Add a new reduction pattern match

[Hideki Saito via Phabricator via llvm-commits]

hsaito added inline comments.


================
Comment at: test/Transforms/LoopVectorize/if-reduction.ll:36
+  %cmp.2 = fcmp fast ogt float %0, 0.000000e+00
+  %add = fadd fast float %0, %sum.1
+  %sum.2 = select i1 %cmp.2, float %add, float %sum.1
----------------
One comment somehow went missing. 

I suggest adding one more negative test, for example, storing %add to y[i]. Single use of %add should be checked, I think. If we find a bug there, that's an easy thing to remedy.


https://reviews.llvm.org/D49168