[PATCH] D49168: [LV] Add a new reduction pattern match

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 8 14:05:32 PDT 2018


rengolin added inline comments.


================
Comment at: lib/Analysis/IVDescriptors.cpp:503
 
+/// Returns true if the instruction has a following chain of instructions.
+/// %sum.1 = phi ...
----------------
hsaito wrote:
> where the Instruction argument I is the last select in the chain.
Good point! Probably better to also rename the argument and simplify the cast in the beginning of the function. I didnĀ“t want to change much, but I guess that's more cosmetic than anything. :)


https://reviews.llvm.org/D49168





More information about the llvm-commits mailing list