[PATCH] D52934: [FPEnv] PatternMatcher support for checking FNEG ignoring signed zeros

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: include/llvm/IR/PatternMatch.h:672
+inline BinaryOp_match<cstfp_pred_ty<is_any_zero_fp>, RHS, Instruction::FSub>
+m_ISZFNeg(const RHS &X) {
+  return m_FSub(m_AnyZeroFP(), X);
----------------
spatel wrote:
> Let's use the existing LLVM vocabulary for "ignore signed zero":
> "m_FNegNSZ"
Thanks, I didn't know that existed.

Do you want "NSZ" to be a suffix? I noticed that the others, like NSW, are prefixed: m_NSWAdd(...).

There are subtle differences between those, so I don't have a strong opinion either way.






https://reviews.llvm.org/D52934