[PATCH] D52974: [XRay][compiler-rt] Generational Buffer Management

[Marcus Boerger via Phabricator via llvm-commits]

mboerger added inline comments.


================
Comment at: compiler-rt/lib/xray/tests/unit/buffer_queue_test.cc:130
+  // Validate that the buffers come from different generations.
+  ASSERT_NE(B0.Generation, B1.Generation);
+
----------------
Why not test B1.Generation > B0.Generation?


================
Comment at: compiler-rt/lib/xray/tests/unit/buffer_queue_test.cc:137
+  // ... and that the new buffer is also accepted.
+  EXPECT_EQ(Buffers.releaseBuffer(B1), BufferQueue::ErrorCode::Ok);
+}
----------------
Test that the next generation is > B1.Generation even after release?


https://reviews.llvm.org/D52974