[llvm] r343948 - [LegalizeDAG] Make one of the ReplaceNode signatures take an ArrayRef instead a pointer to an array. Add assert on size of array. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 7 19:02:09 PDT 2018


Author: ctopper
Date: Sun Oct  7 19:02:08 2018
New Revision: 343948

URL: http://llvm.org/viewvc/llvm-project?rev=343948&view=rev
Log:
[LegalizeDAG] Make one of the ReplaceNode signatures take an ArrayRef instead a pointer to an array. Add assert on size of array. NFC

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp?rev=343948&r1=343947&r2=343948&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Sun Oct  7 19:02:08 2018
@@ -222,10 +222,12 @@ public:
     ReplacedNode(Old.getNode());
   }
 
-  void ReplaceNode(SDNode *Old, const SDValue *New) {
+  void ReplaceNode(SDNode *Old, ArrayRef<SDValue> New) {
+    assert(Old->getNumValues() == New.size() &&
+           "Replacing with a different number of values!");
     LLVM_DEBUG(dbgs() << " ... replacing: "; Old->dump(&DAG));
 
-    DAG.ReplaceAllUsesWith(Old, New);
+    DAG.ReplaceAllUsesWith(Old, New.data());
     for (unsigned i = 0, e = Old->getNumValues(); i != e; ++i) {
       LLVM_DEBUG(dbgs() << (i == 0 ? "     with:      " : "      and:      ");
                  New[i]->dump(&DAG));
@@ -1204,7 +1206,7 @@ void SelectionDAGLegalize::LegalizeOp(SD
         for (unsigned i = 0, e = Node->getNumValues(); i != e; ++i)
           ResultVals.push_back(Res.getValue(i));
         LLVM_DEBUG(dbgs() << "Successfully custom legalized node\n");
-        ReplaceNode(Node, ResultVals.data());
+        ReplaceNode(Node, ResultVals);
         return;
       }
       LLVM_DEBUG(dbgs() << "Could not custom legalize node\n");
@@ -3959,7 +3961,7 @@ bool SelectionDAGLegalize::ExpandNode(SD
   }
 
   LLVM_DEBUG(dbgs() << "Successfully expanded node\n");
-  ReplaceNode(Node, Results.data());
+  ReplaceNode(Node, Results);
   return true;
 }
 
@@ -4286,7 +4288,7 @@ void SelectionDAGLegalize::ConvertNodeTo
   // Replace the original node with the legalized result.
   if (!Results.empty()) {
     LLVM_DEBUG(dbgs() << "Successfully converted node to libcall\n");
-    ReplaceNode(Node, Results.data());
+    ReplaceNode(Node, Results);
   } else
     LLVM_DEBUG(dbgs() << "Could not convert node to libcall\n");
 }
@@ -4741,7 +4743,7 @@ void SelectionDAGLegalize::PromoteNode(S
   // Replace the original node with the legalized result.
   if (!Results.empty()) {
     LLVM_DEBUG(dbgs() << "Successfully promoted node\n");
-    ReplaceNode(Node, Results.data());
+    ReplaceNode(Node, Results);
   } else
     LLVM_DEBUG(dbgs() << "Could not promote node\n");
 }




More information about the llvm-commits mailing list