[PATCH] D52933: Fix incorrect Twine usage in CFGPrinter

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 7 04:28:15 PDT 2018


grosser accepted this revision.
grosser added a comment.

Thanks Marcin for improving the commit message. We all seem to agree that this is the right correction. Hence, I feel this is ready to upstream from my side. As there have been quite some opinions, it would be great to hear if there are any open concerns that should be adressed or if others also feel this LGT(them).

As a minor remark. I would drop the comment about the twine stuff. We cannot have these comments spread all over the code base. Having this documented in the commit message seems sufficient from my perspective.


Repository:
  rL LLVM

https://reviews.llvm.org/D52933





More information about the llvm-commits mailing list