[llvm] r343927 - [ORC] Pass symbol name to discard by const reference.
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 6 16:02:06 PDT 2018
Author: lhames
Date: Sat Oct 6 16:02:06 2018
New Revision: 343927
URL: http://llvm.org/viewvc/llvm-project?rev=343927&view=rev
Log:
[ORC] Pass symbol name to discard by const reference.
This saves some unnecessary atomic ref-counting operations.
Modified:
llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h
llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h
llvm/trunk/include/llvm/ExecutionEngine/Orc/LazyReexports.h
llvm/trunk/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp
llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp
llvm/trunk/lib/ExecutionEngine/Orc/IndirectionUtils.cpp
llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp
llvm/trunk/lib/ExecutionEngine/Orc/LazyReexports.cpp
llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/Core.h Sat Oct 6 16:02:06 2018
@@ -255,7 +255,7 @@ public:
/// Called by JITDylibs to notify MaterializationUnits that the given symbol
/// has been overridden.
- void doDiscard(const JITDylib &JD, SymbolStringPtr Name) {
+ void doDiscard(const JITDylib &JD, const SymbolStringPtr &Name) {
SymbolFlags.erase(Name);
discard(JD, std::move(Name));
}
@@ -275,7 +275,7 @@ private:
/// from the source (e.g. if the source is an LLVM IR Module and the
/// symbol is a function, delete the function body or mark it available
/// externally).
- virtual void discard(const JITDylib &JD, SymbolStringPtr Name) = 0;
+ virtual void discard(const JITDylib &JD, const SymbolStringPtr &Name) = 0;
};
using MaterializationUnitList =
@@ -293,7 +293,7 @@ public:
private:
void materialize(MaterializationResponsibility R) override;
- void discard(const JITDylib &JD, SymbolStringPtr Name) override;
+ void discard(const JITDylib &JD, const SymbolStringPtr &Name) override;
static SymbolFlagsMap extractFlags(const SymbolMap &Symbols);
SymbolMap Symbols;
@@ -344,7 +344,7 @@ public:
private:
void materialize(MaterializationResponsibility R) override;
- void discard(const JITDylib &JD, SymbolStringPtr Name) override;
+ void discard(const JITDylib &JD, const SymbolStringPtr &Name) override;
static SymbolFlagsMap extractFlags(const SymbolAliasMap &Aliases);
JITDylib *SourceJD = nullptr;
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/Layer.h Sat Oct 6 16:02:06 2018
@@ -96,7 +96,7 @@ protected:
SymbolNameToDefinitionMap SymbolToDefinition;
private:
- void discard(const JITDylib &JD, SymbolStringPtr Name) override;
+ void discard(const JITDylib &JD, const SymbolStringPtr &Name) override;
};
/// MaterializationUnit that materializes modules by calling the 'emit' method
@@ -158,7 +158,7 @@ public:
private:
void materialize(MaterializationResponsibility R) override;
- void discard(const JITDylib &JD, SymbolStringPtr Name) override;
+ void discard(const JITDylib &JD, const SymbolStringPtr &Name) override;
ObjectLayer &L;
VModuleKey K;
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/LazyReexports.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/LazyReexports.h?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/LazyReexports.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/LazyReexports.h Sat Oct 6 16:02:06 2018
@@ -165,7 +165,7 @@ public:
private:
void materialize(MaterializationResponsibility R) override;
- void discard(const JITDylib &JD, SymbolStringPtr Name) override;
+ void discard(const JITDylib &JD, const SymbolStringPtr &Name) override;
static SymbolFlagsMap extractFlags(const SymbolAliasMap &Aliases);
LazyCallThroughManager &LCTManager;
Modified: llvm/trunk/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp Sat Oct 6 16:02:06 2018
@@ -85,7 +85,7 @@ private:
std::move(SymbolToDefinition));
}
- void discard(const JITDylib &V, SymbolStringPtr Name) override {
+ void discard(const JITDylib &V, const SymbolStringPtr &Name) override {
// All original symbols were materialized by the CODLayer and should be
// final. The function bodies provided by M should never be overridden.
llvm_unreachable("Discard should never be called on an "
Modified: llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/Core.cpp Sat Oct 6 16:02:06 2018
@@ -489,7 +489,7 @@ void AbsoluteSymbolsMaterializationUnit:
}
void AbsoluteSymbolsMaterializationUnit::discard(const JITDylib &JD,
- SymbolStringPtr Name) {
+ const SymbolStringPtr &Name) {
assert(Symbols.count(Name) && "Symbol is not part of this MU");
Symbols.erase(Name);
}
@@ -637,7 +637,7 @@ void ReExportsMaterializationUnit::mater
}
void ReExportsMaterializationUnit::discard(const JITDylib &JD,
- SymbolStringPtr Name) {
+ const SymbolStringPtr &Name) {
assert(Aliases.count(Name) &&
"Symbol not covered by this MaterializationUnit");
Aliases.erase(Name);
Modified: llvm/trunk/lib/ExecutionEngine/Orc/IndirectionUtils.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/IndirectionUtils.cpp?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/IndirectionUtils.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/IndirectionUtils.cpp Sat Oct 6 16:02:06 2018
@@ -41,7 +41,7 @@ private:
R.emit();
}
- void discard(const JITDylib &JD, SymbolStringPtr Name) override {
+ void discard(const JITDylib &JD, const SymbolStringPtr &Name) override {
llvm_unreachable("Discard should never occur on a LMU?");
}
Modified: llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/Layer.cpp Sat Oct 6 16:02:06 2018
@@ -53,7 +53,8 @@ StringRef IRMaterializationUnit::getName
return "<null module>";
}
-void IRMaterializationUnit::discard(const JITDylib &JD, SymbolStringPtr Name) {
+void IRMaterializationUnit::discard(const JITDylib &JD,
+ const SymbolStringPtr &Name) {
LLVM_DEBUG(JD.getExecutionSession().runSessionLocked([&]() {
dbgs() << "In " << JD.getName() << " discarding " << *Name << " from MU@"
<< this << " (" << getName() << ")\n";
@@ -145,7 +146,7 @@ void BasicObjectLayerMaterializationUnit
}
void BasicObjectLayerMaterializationUnit::discard(const JITDylib &JD,
- SymbolStringPtr Name) {
+ const SymbolStringPtr &Name) {
// FIXME: Support object file level discard. This could be done by building a
// filter to pass to the object layer along with the object itself.
}
Modified: llvm/trunk/lib/ExecutionEngine/Orc/LazyReexports.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/LazyReexports.cpp?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/LazyReexports.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/LazyReexports.cpp Sat Oct 6 16:02:06 2018
@@ -187,7 +187,7 @@ void LazyReexportsMaterializationUnit::m
}
void LazyReexportsMaterializationUnit::discard(const JITDylib &JD,
- SymbolStringPtr Name) {
+ const SymbolStringPtr &Name) {
assert(CallableAliases.count(Name) &&
"Symbol not covered by this MaterializationUnit");
CallableAliases.erase(Name);
Modified: llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h?rev=343927&r1=343926&r2=343927&view=diff
==============================================================================
--- llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h (original)
+++ llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h Sat Oct 6 16:02:06 2018
@@ -112,7 +112,8 @@ public:
Materialize(std::move(R));
}
- void discard(const orc::JITDylib &JD, orc::SymbolStringPtr Name) override {
+ void discard(const orc::JITDylib &JD,
+ const orc::SymbolStringPtr &Name) override {
if (Discard)
Discard(JD, std::move(Name));
else
More information about the llvm-commits
mailing list