[llvm] r343924 - [X86][AVX] Ensure resolveTargetShuffleInputs shuffle masks are the correct width

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 6 10:18:42 PDT 2018


Author: rksimon
Date: Sat Oct  6 10:18:41 2018
New Revision: 343924

URL: http://llvm.org/viewvc/llvm-project?rev=343924&view=rev
Log:
[X86][AVX] Ensure resolveTargetShuffleInputs shuffle masks are the correct width

Don't handle ZERO_EXTEND style shuffles until we support bitcasts. Found by inspection.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=343924&r1=343923&r2=343924&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sat Oct  6 10:18:41 2018
@@ -6393,7 +6393,8 @@ static bool getFauxShuffleMask(SDValue N
       return false;
     SmallVector<int, 64> SubMask;
     SmallVector<SDValue, 2> SubInputs;
-    if (!resolveTargetShuffleInputs(Sub, SubInputs, SubMask, DAG))
+    if (!resolveTargetShuffleInputs(Sub, SubInputs, SubMask, DAG) ||
+        SubMask.size() != NumSubElts)
       return false;
     Ops.push_back(Src);
     for (SDValue &SubInput : SubInputs) {




More information about the llvm-commits mailing list