[PATCH] D52748: [WebAssembly] LSDA info generation

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/WasmException.cpp:42
+
+  // Wasm requires every data section symbol to have a .size set. So we emit an
+  // end marker and set the size as the difference between the start end the end
----------------
dschuff wrote:
> Is there some particular reason for this or is it just a limitation of our assembler and/or MC?
Looks like wasm object writer & obj2yaml are structured to save sizes for data symbols. The size information is also shown in obj2yaml. I guess this info is used in the symbol table, and not elsewhere (so the final binary works without this info). We can do away with setting size for now if we really want, but I'm not sure if it's good to modify the symbol table structure, and the size info might be needed later for debug info or something..? @sbc100, what do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D52748