[PATCH] D52887: [DebugInfo][Dexter] Unreachable line stepped onto after SimplifyCFG.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

The code looks fine, I have some comments about the comments.



================
Comment at: lib/Transforms/Utils/Local.cpp:2535
+  // Since we are moving the instructions out of its basic block, we do not
+  // retain their original debug location and debug intrinsic instructions.
+  // Doing so would degrade the debugging experience and adversely affect the
----------------
CarlosAlbertoEnciso wrote:
> CarlosAlbertoEnciso wrote:
> > vsk wrote:
> > > aprantl wrote:
> > > > Please also explain why if possible. I think the reason is different for DILoctions and dbg.values.
> > > Right. Moving locations around degrades single-stepping and profiling. Moving dbg.values around makes variable updates appear re-ordered in a debug session.
> > Updated the comments to include a better explanation about the actions taken on DILocations and dbg.values.
> Taking your feedback, as the base for the updated comments.
Just to be clear: When I said "please explain" I meant: in the comment in the code, not to me in the review :-)


https://reviews.llvm.org/D52887