[PATCH] D52927: [CodeGen] Fix for PR39094.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 5 08:54:44 PDT 2018


aprantl added a comment.

a testcase would be nice, but generally this looks fine.



================
Comment at: include/llvm/CodeGen/SlotIndexes.h:416
       // Instructions inside a bundle have the same number as the bundle itself.
-      const MachineInstr &BundleStart = *getBundleStart(MI.getIterator());
-      assert(!BundleStart.isDebugInstr() &&
+      MachineBasicBlock::const_iterator BundleStart = getBundleStart(
+                                                          MI.getIterator());
----------------
please clang-format your patch.

Does `auto` work here? It might make the code easier to read.


Repository:
  rL LLVM

https://reviews.llvm.org/D52927





More information about the llvm-commits mailing list