[PATCH] D52904: [hot-cold-split] fix static analysis of cold regions

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 5 08:20:35 PDT 2018


sebpop updated this revision to Diff 168476.
sebpop added a comment.

Added an early return for outlining if function entry is cold.
Added a check for invoke calls: invoke should not be marked as cold by back propagation.

There are only a few cold regions that are now extracted with the static analysis of hot/cold blocks on a relatively large benchmark.
Through those extracted blocks there are some diamonds that do not contain much code.
We may want to avoid outlining a candidate cold region if the number of instructions in the region is too low.


https://reviews.llvm.org/D52904

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/test/Transforms/HotColdSplit/split-cold-1.ll
  llvm/test/Transforms/HotColdSplit/split-cold-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52904.168476.patch
Type: text/x-patch
Size: 4817 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181005/48c3dbea/attachment.bin>


More information about the llvm-commits mailing list