[PATCH] D52934: [FPEnv] PatternMatcher support for checking FNEG ignoring signed zeros

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 5 08:16:13 PDT 2018


cameron.mcinally added inline comments.


================
Comment at: lib/Analysis/InstructionSimplify.cpp:4512
+    if ((match(Op0, m_ISZFNeg((m_Value(X)))) && X == Op1) ||
+        (match(Op1, m_ISZFNeg((m_Value(X)))) && X == Op0))
       return ConstantFP::get(Op0->getType(), -1.0);
----------------
Quick note:

I was torn here about adding a second pointer temp for Op1's captured element. But, I believe that C++'s sequence points guarantee that the reuse of X is safe.


Repository:
  rL LLVM

https://reviews.llvm.org/D52934





More information about the llvm-commits mailing list