[PATCH] D52932: [MCSched] Bind PFM Counters to the CPUs instead of the SchedModel.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 5 06:50:54 PDT 2018
courbet marked an inline comment as done.
courbet added a comment.
Thanks
================
Comment at: utils/TableGen/SubtargetEmitter.cpp:1892
OS << '\n'; OS.indent(22);
- OS << Target << "ProcSchedKV, "
- << Target << "WriteProcResTable, "
- << Target << "WriteLatencyTable, "
- << Target << "ReadAdvanceTable, ";
+ OS << Target << "ProcSchedKV, " << Target << "ProcPfmKV, " << Target
+ << "WriteProcResTable, " << Target << "WriteLatencyTable, " << Target
----------------
gchatelet wrote:
> llvm::format would help here
> ```
> OS << llvm::format("{0}ProcSchedKV, {0}ProcPfmKV, {0}WriteProcResTable, {0}WriteLatencyTable, {0}ReadAdvanceTable, ", Target);
> ```
I want to remain consistent with the rest of the file. I've reformatted to make it more readable.
Repository:
rL LLVM
https://reviews.llvm.org/D52932
More information about the llvm-commits
mailing list