[PATCH] D52557: AMDGPU: Consolidate SMRD TableGen patterns

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

Nice. Patch LGTM except for one cosmetic issue. No need to update on Phabricator before commit as far as I'm concerned.



================
Comment at: lib/Target/AMDGPU/SMInstructions.td:749-750
+
+// Name the pattern to reuse AddedComplexity on CI
+defm SM_LOAD_PATTERN : SMLoad_Pattern <"S_BUFFER_LOAD_DWORD",     i32>;
+defm : SMLoad_Pattern <"S_BUFFER_LOAD_DWORDX2",   v2i32>;
----------------
This patch removes the only place where SM_LOAD_PATTERN.AddedComplexity is used, so the comment should be removed, and the defm name should be removed as well to keep things consistent.


Repository:
  rL LLVM

https://reviews.llvm.org/D52557