[PATCH] D52895: [TailCallElim] Enable marking of calls with byval as tails

Robert Lougher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 18:00:34 PDT 2018


rob.lougher added a comment.

In https://reviews.llvm.org/D52895#1256101, @rob.lougher wrote:

>




> Unfortunately we would still need this change. A nocapture argument is not an escape point but it is still a user of the alloca, which prevents the call from being marked tail.

In case I wasn't clear. A byval argument is neither an escape point or a user of the alloca. A nocapture argument is simply not an escape point. They are not the same, and this check is necessary to correctly handle byval.


Repository:
  rL LLVM

https://reviews.llvm.org/D52895





More information about the llvm-commits mailing list