[PATCH] D52837: [WebAssembly] Ignore DBG_VALUE in WebAssemblyCFGStackify pass when looking for block start

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 16:12:54 PDT 2018


aheejin added a comment.

In https://reviews.llvm.org/D52837#1256006, @yurydelendik wrote:

> > And I don't think we need the BEFORE check... what I meant by the 'before' check in the comment above was, before your fix, the wrong code sequence generated was like that.
>
> `CHECK-BEFORE` is a sanity check in case if some of the passes decide to rearrange the instructions or remove DBG_VALUE. Maybe it was an overkill.
>
> Thank you for the reduced test case.


Oh sorry. Then maybe we're better to have it. Could you bring it back?...


Repository:
  rL LLVM

https://reviews.llvm.org/D52837





More information about the llvm-commits mailing list