[PATCH] D52831: [lit] Only return a found bash executable on Windows if it can understand Windows paths
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 4 15:51:32 PDT 2018
zturner added a comment.
In https://reviews.llvm.org/D52831#1255897, @gbedwell wrote:
> execute_external && isWindows -> 'cmd.exe'
>
My suggestion is to make this case assert. It should not ever happen. `execute_external` should imply not-windows
https://reviews.llvm.org/D52831
More information about the llvm-commits
mailing list