[PATCH] D52878: [test-suite] Add flags for stdthreadbug.cpp when building static

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 14:47:52 PDT 2018


nemanjai added a comment.

Also, please always publish Phabricator reviews with full context.



================
Comment at: SingleSource/UnitTests/C++11/CMakeLists.txt:2
 list(APPEND CXXFLAGS -std=c++11 -pthread)
-list(APPEND LDFLAGS -lstdc++ -pthread)
+list(APPEND LDFLAGS -lstdc++ -pthread -Wl,--whole-archive -lpthread -Wl,--no-whole-archive)
 llvm_singlesource()
----------------
As a PPC-Linux guy, I don't really see an issue with this change. However, I am a bit concerned about whether this is portable to other targets. Windows certainly comes to mind - I have no idea how this type of stuff works there (or if test-suite even works there).


Repository:
  rT test-suite

https://reviews.llvm.org/D52878





More information about the llvm-commits mailing list