[PATCH] D52793: Introduce internal_sysctlbyname in place of sysctlbyname

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_netbsd.cc:96
   CHECK(real_##func);
 #define DEFINE_INTERNAL(ret_type, func, ...) \
   ret_type internal_##func(__VA_ARGS__)
----------------
vitalybuka wrote:
> I don't see how DEFINE_INTERNAL is helpful
> 
> the following looks better:
> uptr internal_mmap(void *addr, uptr length, int prot, int flags, int fd, OFF_T offset) {
> }
> 
I will unroll it in a new revision.


Repository:
  rL LLVM

https://reviews.llvm.org/D52793