[PATCH] D52294: [InstCombine] Fix incongruous GEP type addrspace

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

LGTM, but let's see if @lebedev.ri has any other feedback before marking as approved.



================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:2059
+              ? Builder.CreateInBoundsGEP(nullptr, SrcOp,
+                                          makeArrayRef(Ops).slice(1))
+              : Builder.CreateGEP(nullptr, SrcOp, makeArrayRef(Ops).slice(1));
----------------
Nit: since we know there are only 3 operands here, it would be less ambiguous to use something like { Op[1], Op[2] } here?


Repository:
  rL LLVM

https://reviews.llvm.org/D52294