[PATCH] D52904: [hot-cold-split] fix static analysis of cold regions

[Sebastian Pop via Phabricator via llvm-commits]

sebpop created this revision.
sebpop added reviewers: hiraditya, tejohnson, brzycki.

Make the code of blockEndsInUnreachable to match the function
blockEndsInUnreachable in CodeGen/BranchFolding.cpp. I also have
added a note to make sure the code of this function will not be
modified unless the back-end version is also modified.

      

We used to mark the whole function as cold by back-propagation
because the back-propagation would mark blocks with return
statements as cold.

      

The patch adds debug statements to help discover these problems.


https://reviews.llvm.org/D52904

Files:
  llvm/lib/Transforms/IPO/HotColdSplitting.cpp
  llvm/test/Transforms/HotColdSplit/split-cold-1.ll
  llvm/test/Transforms/HotColdSplit/split-cold-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52904.168362.patch
Type: text/x-patch
Size: 4273 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181004/62ff65be/attachment.bin>