[PATCH] D49795: [PPC64] Position-independent long-branch thunks.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 12:45:01 PDT 2018


sfertile added a comment.

In https://reviews.llvm.org/D49795#1254181, @ruiu wrote:

> This patch seems a bit too intrusive to me, but I'm not sure if it is unavoidable (and thus this is a straightforward implementation) or there's another way to implement it.


This isn't something that is dictated by the ABI  and its entirely constrained to the module being linked so we are free design something less invasive.  This implementation was chosen mostly to match what ld.gold implements. I think your suggestion of treating a long branch target as a regular .got.plt entry is feasible, but I'll likely have to make a small change in Symbol since the PltIndex does double duty for the GotPlt offset as well as determining if a symbol is in the plt.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49795





More information about the llvm-commits mailing list